setup.py -> pyproject.toml, and mv tap to src #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make tap's structure a bit safer. Here are the changes:
setup.py
w/ a staticpyproject.toml
. See docstap
tosrc/tap
. See docstap.__version__
as a literal stringFrom the user's perspective, I believe there aren't any breaking changes. But in case you prefer making the most minimal change to fix #141, it would be to add a
pyproject.toml
which looks like this:How has this been tested?
Install the fork
Make and activate a fresh venv (I use virtualenvwrapper)
Uninstall
wheel
,setuptools
Install the package from the fork
Install
pytest
andpydantic
, and runpytest
rm temp
Build, test-upload, install, and test the package
Checkout this branch:
Make and activate a fresh venv (I use virtualenvwrapper)
Install some packaging things
Build the package
dist/
should have:Test the contents of
dist/
Test that fake-uploading to PyPI works (I haven't actually ran this step onwards)
You may wanna also check that https://test.pypi.org/project/typed-argument-parser looks good
Test that installing from this test PyPI repo works
Install
pytest
andpydantic
, and runpytest
Maybe run some of the demo scripts in the repo in case you wanna double check
rm temp