Fixing bug in as_dict for subclass Taps

tap/_version.py

@@ -1,7 +1,7 @@
 __all__ = ['__version__']
 
 # major, minor, patch
-version_info = 1, 5, 1
+version_info = 1, 5, 2
 
 # Nice string for the version
 __version__ = '.'.join(map(str, version_info))

tap/tap.py

@@ -437,7 +437,10 @@ def as_dict(self) -> Dict[str, Any]:
             raise ValueError('You should call `parse_args` before retrieving arguments.')
 
         self_dict = self.__dict__
-        class_dict = {key: val for key, val in type(self).__dict__.items() if key not in self_dict}
+        class_dict = self._get_from_self_and_super(
+            extract_func=lambda super_class: dict(getattr(super_class, '__dict__', dict()))
+        )
+        class_dict = {key: val for key, val in class_dict.items() if key not in self_dict}
         stored_dict = {**self_dict, **class_dict}
 
         stored_dict = {

tests/test_integration.py

@@ -924,6 +924,23 @@ def pi(self):
         as_dict_res = {'a': 'hi', 'b': 1, 'pi': 3.14}
         self.assertEqual(args.as_dict(), as_dict_res)
 
+    def test_as_dict_superclass_property(self):
+        class SuperPropertyTap(Tap):
+            a: str
+
+            @property
+            def pi(self):
+                return 3.14
+
+        class SubPropertyTap(SuperPropertyTap):
+            b: int = 1
+
+        args = SubPropertyTap()
+        args = args.parse_args(['--a', 'hi'])
+
+        as_dict_res = {'a': 'hi', 'b': 1, 'pi': 3.14}
+        self.assertEqual(args.as_dict(), as_dict_res)
+
 
 class TestFromDict(TestCase):