Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed operation when there is a newline character between annotations #1846

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed operation when there is a newline character between annotations #1846

wants to merge 2 commits into from

Conversation

mahiworld
Copy link

This change resolves issue #1839 by adding the parse newline annotation and throw an error: newline detected between annotations.
Issue: #1839

@ubogdan
Copy link
Contributor

ubogdan commented Oct 20, 2024

Cool! What about unit tests?

@ubogdan
Copy link
Contributor

ubogdan commented Oct 21, 2024

@mahiworld in case you missed my reply.
If you want to get this merged you need to provide unit test to cover the code you added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahiworld @ubogdan