feat: ParseComment error to contain the comment #1777
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdghchj
previously approved these changes
Mar 21, 2024
|
@stokito can you please fix the conflicts. |
When a comment has an error then we print only a file name and the error text but not the comment that caused an error. To make it easier to understand a problem print it. Also change an error itself to make it easier to google.
stokito
force-pushed
the
parse_comment
branch
from
a7ca68f
to
613b2fa
Compare
|
rebased |
|
@stokito Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a comment has an error then we print only a file name and the error text but not the comment that caused an error. To make it easier to understand print it.
Context:
I spent a lot of time while investigating the error message:
It turned out that the DTO was fine but a problem was in another place with a comment:
In the comment instead of
UserKeyit was writtenUser Keyand the Key was threatened as aparamType. I wasn't able to figure out which key they are talking about.So the change should significantly improve troubleshooting which is important.