Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a clock that stays on top of advertisements with a small half-see through oval. #128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CH10N
Copy link

@CH10N CH10N commented May 6, 2024

No description provided.

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

image

Though, here it's not that visible. Perhaps make the black less transparent?

image

Also, it will hover above the ad, obstructing some text. Do you think it will be difficult to move the clock to a corner, and make it smaller, when an ad is played? Perhaps this can be achieved by giving the clock a different class when going to a state where an ad is displayed.

@@ -19,6 +19,7 @@ export default class App extends Component {
}

next() {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this when done

@JAartsPanda JAartsPanda linked an issue Nov 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show clock over advertisments
2 participants