Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Housekeeping Process for DAGMC #943

Merged
merged 11 commits into from
Feb 22, 2024
31 changes: 18 additions & 13 deletions .github/workflows/housekeeping.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Housekeeping checks
name: Housekeeping Checks

on:
# allows us to run workflows manually
Expand All @@ -8,21 +8,22 @@ on:
- develop

jobs:
Housekeeping:
main:
runs-on: ubuntu-latest
container:
image: ghcr.io/svalinn/dagmc-ci-ubuntu-18.04-housekeeping:stable
steps:
- name: Checkout repository
uses: actions/checkout@v3

steps:
- name: Setup environment
run: |
echo "REPO_SLUG=${GITHUB_REPOSITORY}" >> $GITHUB_ENV
echo "PULL_REQUEST=$(echo $GITHUB_REF | cut -d"/" -f3)" >> $GITHUB_ENV
mkdir /root/build_dir
ln -s $GITHUB_WORKSPACE /root/build_dir/DAGMC


- name: Setup dependencies
run: |
sudo apt-get install -y clang-format

- name: Checkout repository
uses: actions/checkout@v3

- name: Housekeeping
run: |
cd $GITHUB_WORKSPACE
Expand All @@ -32,10 +33,14 @@ jobs:
-exec clang-format -style=file -i {} \;
clang_diffs=`git status --porcelain`
if [ -z "${clang_diffs}" ]; then
echo "Style guide checker passed!"
echo -e "\033[32mStyle guide checker passed!\033[0m"
else
echo "ERROR: Style guide checker failed. Please run clang-format."
echo "clang_diffs: ${clang_diffs}"
echo -e "\033[1;31mERROR: Style guide checker failed. Please run clang-format.\033[0m"
echo
echo -e "\033[33mClang diffs:\033[0m"
echo "${clang_diffs}"
echo
echo -e "\033[33mGit diff:\033[0m"
git diff
exit 1
fi
7 changes: 0 additions & 7 deletions CI/Dockerfile_1_housekeeping

This file was deleted.

1 change: 1 addition & 0 deletions doc/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Next version
* Update hdf5 to v1.14.3 from v1.10.4 (#931 #933)
* Ensure implicit complement handle is placed at the back of DAGMC volume indices (#935)
* Update MOAB to 5.5.1 from 5.3.0 (#939 #940)
* Simplify Housekeeping Process for DAGMC (#943)

v3.2.3
====================
Expand Down
Loading