Fix order of attribute initialization #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this @gonuke, @shimwell? https://github.com/svalinn/DAGMC/actions/runs/6039003224/job/16386661208
|
|
This is currently expected to fail. |
|
This test should no longer be run on PRs after my most recent PR (if you rebase?) |
I'd expect #902 to fail due to the additional flags used in CI, but this PR reorders the class attribute initialization so I'd expect it to pass. Am I missing something? |
|
This failing action is to test against new versions of Geant. I don't see it in your checks for this PR. |
|
Oh "this" being the CI build, not the PR itself. Though in the end I suppose the outcome is the same... All looks well on this PR though 👍🏻 Sorry for the cross-talk. |
gonuke
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the issue referenced in #902 and is shown in this CI build failure for that PR.
Motivation and Context
Enables builds of DAGMC with MOOSE apps without failure.
Changes
Small refactor of the metadata class.