Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Django 2.2 made HttpResponse headers public field #50

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

galuszkak
Copy link
Contributor

No description provided.

@galuszkak
Copy link
Contributor Author

galuszkak commented Jul 31, 2021

Change is mentioned here:
https://docs.djangoproject.com/en/3.2/releases/2.2/#requests-and-responses

I wonder why tests didn't fail on this in new Django.

Also I think we should fix #49 and have some CI (either Travis or move to GitHub Actions).

@dekoza dekoza merged commit 2b61ad2 into sunscrapers:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants