This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
<DRAFT>Support for Virtual Table with input as rows of expressions #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshuldata
commented
Oct 30, 2024
•
anshuldata
commented
- This PR needs some changes to duckdb repo. I have currently pushed to my own fork (here). We need to figure out how to get these changes in sundeck duckdb-extension repo. Currently duckdb is a submodule linked to main duckdb repo so can't directly push these changes
- Added updated Proto
- Introduced changes to support virtual tables having expressions as value
|
Let's always do substrait proto bumps as separate prs. Can you separate here please? |
| break; | ||
| case JoinType::SEMI: | ||
| sjoin->set_type(substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_SEMI); | ||
| sjoin->set_type(substrait::JoinRel::JoinType::JoinRel_JoinType_JOIN_TYPE_LEFT_SEMI); |
There was a problem hiding this comment.
This maintains support for the existing types but how are the new types handled?
There was a problem hiding this comment.
For newly introduced types currently error "Unsupported join type" is returned. New type will be enhanced in future PR. With this PR I intended to update proto and fix breaking change
|
I will raise a separate PR for proto changes so converting this PR to draft. Once proto PR is merged, I will un-draft this PR |
anshuldata
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.