Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash #1044

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Remove lodash #1044

merged 1 commit into from
Nov 18, 2024

Conversation

connor-baer
Copy link
Member

Purpose

Lodash doesn't play well with ES modules and bloats Foundry's install size.

Approach and changes

  • Replace most lodash helpers with simple internal implementations
  • Replace lodash.merge with deepmerge-ts

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 64fd88c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@connor-baer connor-baer merged commit 96eda02 into next Nov 18, 2024
6 checks passed
@connor-baer connor-baer deleted the chore/replace-lodash branch November 18, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant