-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove scarf analytics #567
Conversation
Codecov Report
@@ Coverage Diff @@
## version-4-1-1 #567 +/- ##
=================================================
Coverage ? 100.00%
=================================================
Files ? 89
Lines ? 846
Branches ? 309
=================================================
Hits ? 846
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Co-authored-by: Brian Hough <[email protected]>
Hi @mansona, author of the Scarf package here. From the description for the PR, I just wanted to clarify a few points because it seems there may be some misunderstandings here. I described this a bit in another thread that I happened to see first (#559 (comment)) but to summarize here:
cc @bhough I hope you'll consider resuming the use of Scarf in this project, but either way, thanks for all of your open-source work and thanks for your time! :) |
Hey folks 👋
I'm just opening up this PR to remove the
@scarf/scarf
analytics package from polished.I don't want to get into too much of a philosophical conversation about analytics or ethics but I would say that the package is potentially a GDPR violation (as it does not work on an opt-in basis) and there are some serious problems with the implementation of scarf as it currently doesn't allow you opt-out if you are using yarn scarf-sh/scarf-js#3
Cheers!