Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scarf analytics #567

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Feb 17, 2021

Hey folks 👋

I'm just opening up this PR to remove the @scarf/scarf analytics package from polished.

I don't want to get into too much of a philosophical conversation about analytics or ethics but I would say that the package is potentially a GDPR violation (as it does not work on an opt-in basis) and there are some serious problems with the implementation of scarf as it currently doesn't allow you opt-out if you are using yarn scarf-sh/scarf-js#3

Cheers!

@mansona mansona requested a review from bhough as a code owner February 17, 2021 09:30
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

❗ No coverage uploaded for pull request base (version-4-1-1@99fb4a1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             version-4-1-1      #567   +/-   ##
=================================================
  Coverage                 ?   100.00%           
=================================================
  Files                    ?        89           
  Lines                    ?       846           
  Branches                 ?       309           
=================================================
  Hits                     ?       846           
  Misses                   ?         0           
  Partials                 ?         0           
Flag Coverage Δ
unittests 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fb4a1...33de0fb. Read the comment docs.

@bhough bhough added the dependencies Pull requests that update a dependency file label Feb 17, 2021
@bhough bhough changed the base branch from main to version-4-1-1 February 17, 2021 11:08
@bhough bhough merged commit 10a99dc into styled-components:version-4-1-1 Feb 17, 2021
bhough added a commit that referenced this pull request Feb 17, 2021
@aviaviavi
Copy link

aviaviavi commented Feb 18, 2021

Hi @mansona, author of the Scarf package here. From the description for the PR, I just wanted to clarify a few points because it seems there may be some misunderstandings here. I described this a bit in another thread that I happened to see first (#559 (comment)) but to summarize here:

  • For yarn: Scarf disables itself entirely during yarn installs, so no analytics are reported at all. It is a firm development guideline for Scarf that analytics are never reported without informing the user, so the analytics hooks are never triggered in a yarn installation. I'll update our docs to better communicate that.
  • No personally-identifiable information is being stored by Scarf, so the consent requirements of GDPR are not triggered here. Scarf offers various opt-out mechanisms on basic principle and for convenience, but not due to legal requirements.

cc @bhough

I hope you'll consider resuming the use of Scarf in this project, but either way, thanks for all of your open-source work and thanks for your time! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants