Issue/102 #119
Merged
Issue/102 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that anyone calling tcp_cache_set() directly in their own custom code has a more reliable idea of whether this method call has failed.
This commit strictly divides the TCP cache methods to stop storing a local copy of the remote cache when a persistent cache exists elsewhere. It also adds expirations to the local cache, in the event that the PHP request is allowed to process and hang for longer than the servers have collectively to be checked.
Even for master. No matter the tries remaining. If TCP responsiveness is being checked and the connection to master goes down, it will exist in the cache.
Renames some protected methods to better match their intended TCP usages. Because WordPress loads WPDB before the object cache, the persistent TCP cache implementation needs to carefully start the object cache manually. Fixes #126.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #102