Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update JPEG 2000 and HT tests to Catch2 #1369

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Nov 5, 2024

No description provided.

@farindk farindk merged commit 36c9860 into strukturag:master Nov 5, 2024
35 checks passed
@bradh bradh deleted the catch2_2024-11-05 branch November 5, 2024 09:18
@farindk
Copy link
Contributor

farindk commented Nov 5, 2024

FYI: I'll have to revert back to the amalgamated catch2 code because downloading the latest version during building does not work for the packaging people...

@bradh
Copy link
Contributor Author

bradh commented Nov 5, 2024

FYI: I'll have to revert back to the amalgamated catch2 code because downloading the latest version during building does not work for the packaging people...

Can we just require the package instead?

@farindk
Copy link
Contributor

farindk commented Nov 5, 2024

Ubuntu 22.04 is currently at catch2 v2.13.8 (3 years behind).

@bradh
Copy link
Contributor Author

bradh commented Nov 5, 2024

Ubuntu 22.04 is currently at catch2 v2.13.8 (3 years behind).

https://launchpad.net/~fenics-packages/+archive/ubuntu/fenics will get you back to 22.04.

So in the CMake logic, check if its already available, and only download if not.

Then in CI, apply that PPA (or another, like https://launchpad.net/~savoury1/+archive/ubuntu/build-tools), install the package, and it should be found at build time (hence no download).

@fancycode
Copy link
Member

Ubuntu 22.04 is currently at catch2 v2.13.8 (3 years behind).

https://launchpad.net/~fenics-packages/+archive/ubuntu/fenics will get you back to 22.04.

So in the CMake logic, check if its already available, and only download if not.

Then in CI, apply that PPA (or another, like https://launchpad.net/~savoury1/+archive/ubuntu/build-tools), install the package, and it should be found at build time (hence no download).

The problem is in packaging where you only have access to official repositories, i.e. no PPAs, downloads or git checkouts.

@farindk
Copy link
Contributor

farindk commented Nov 5, 2024

This issue is because of packaging, not the CI.
As I understand it, when cmake runs, it's already too late to decide whether a current version is available.
It has to be specified as a build-dependency and if that is not available, the code has to be included. (see #1362)

I'm not sure whether an external PPA would work, but my guess is no, because of security issues.

@bradh
Copy link
Contributor Author

bradh commented Nov 5, 2024

But if you're packaging on 24.04 (for example), then you should have an up-to-date version of Catch2 (3.4.0 in my install), right?

Its only a problem for building PPAs for older distros?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants