Adding a new emscripten js method to parse depth images #1029
Conversation
Dakantz
changed the title
|
Thanks. One thing, though: your PR contains a lot of code reformatting in unrelated parts. Could you please clean up the PR such that only your new code is contained? Also make sure not to merge "master" into your branch. This will make the history unnecessarily complicated. |
|
Sorry for the merge and formatting mistake, should be fixed now! This is one of my first PRs 😅 I hope it can be merged now! |
| return depth_result; | ||
| } | ||
|
|
||
| depth_result.set("testdata", emscripten::val(emscripten::typed_memory_view(10, "123456890"))); |
There was a problem hiding this comment.
looks like this is a leftover from testing
| depth_result.set("data", emscripten::val(emscripten::typed_memory_view(stride * height, plane))); | ||
| depth_result.set("buffersize", stride * height); | ||
| depth_result.set("channel", channel); | ||
| depth_result.set("testdata", emscripten::val(emscripten::typed_memory_view(10, "123456890"))); |
|
@EzraH442 Could you please do a review on this PR (only the changes in the file |
| { | ||
| depth_result.set("err", "could not get handle of depth image"); | ||
| depth_result.set("id", depth_image_id); | ||
| return depth_result; | ||
| } |
| depth_result.set("err", "could not get image of depth image"); | ||
| depth_result.set("msg", err.message); | ||
| depth_result.set("id", depth_image_id); | ||
| return depth_result; |
| heif_item_id *ids = (heif_item_id *)malloc(n_images * sizeof(heif_item_id)); | ||
|
|
There was a problem hiding this comment.
Also here there should be a check to make sure the malloc didn't return a null pointer, similar to here
| depth_result.set("id", depth_image_id); | ||
| return depth_result; | ||
| } | ||
| static emscripten::val heif_js_get_depth_imgs_decoded(struct heif_image_handle *handle) |
There was a problem hiding this comment.
based on what this function does a better name might be heif_js_image_handle_get_depth_img_handle, since it doesn't actually do any image decoding
| } | ||
| } | ||
|
|
||
| depth_result.set("err", "could get no plane of depth image"); |
There was a problem hiding this comment.
This might be a little bit pedantic but I'd rephrase this error message to "could not get plane of depth image"
Adding a new emscripten js method to parse depth images