Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Rename IdSiteModel to IdSite #545

Open
wants to merge 1 commit into
base: 1.0.0
Choose a base branch
from

Conversation

the-overengineer
Copy link

Renamed the file and class. Foundnd all references in documents and tests and updated them.

Fixes #537

@coveralls
Copy link

coveralls commented Sep 19, 2016

Coverage Status

Coverage remained the same at 89.135% when pulling 21b0824 on feature-rename-id-sites-model into d5d09e6 on master.

@typerandom
Copy link
Contributor

typerandom commented Sep 19, 2016

@Tweety-FER Thanks! Unfortunately after more investigation it looks as if the IdSiteModel is "correctly named". I.e. the resource is actually named idSiteModel. Which in my opinion is a little bit confusing, but it seems that the resource name is like that.

@robertjd Do you have any input here?

@robertjd
Copy link
Member

Ah! I see where the confusion is here. There are two resources in the REST API:

  • The ID Site Model is a view of other data that is fetched from application/:id/idSiteModel - it's not a modifiable resource.
  • The ID Site is a real resource, that contains the configuration information for an ID Site. This is a real resource that can be updated (but not deleted, there one per tenant right now).

Thus, this PR has some correct changes, but some incorrect changes. The following should be true:

  • Application.getIdSiteModel() should return IdSiteModel
  • Organization.getIdSiteModel() should return IdSiteModel
  • Tenant.getIdSites() should return IdSite

Ping @Tweety-FER for changes, thanks!

@robertjd robertjd changed the base branch from master to 1.0.0 November 23, 2016 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants