Add support for setting registration fields from account schema #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fields are null by default * Warnings if there are configuration mis-matches * Directory schema requirements override local disabling of requirements * Stub out tests
|
@typerandom this needs some work, based on what we decided for the framework-spec. I've made the necessary changes and they work as I expect. But this needs tests before we can merge. |
… the remote value
… the remote value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for setting registration fields from the account schema.
How to verify
Add
console.log('Setting field!', field);afterwebConfig.register.form.fields[field.name].required = field.required;inlib/strategy/EnrichIntegrationFromRemoteConfigStrategy.js. Then run this branch with theexpress-stormpathtest application and verify thatSetting field (field)is written to the console for thegivenNameandsurnamefields.Important
This depends on features from stormpath/stormpath-sdk-node#534 so that PR needs to be merged before.