This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates new Node SDK
client_credentials
authenticator and adds support for scope factories.Depends on stormpath/stormpath-sdk-node#575 PR in the Node SDK and will not work without it. This PR allows the
OAuthAuthenticator
class to proxy the scope factory and signing key between the Express app and the concrete authenticator instances.The scope factory is set as a property in the config (
config.web.scopeFactory
), and will be used if defined there. The client secret will be used automatically, and no configuration is required.It adds support for sending the client id and secret as parameters, but remains backwards-compatible with sending them via the
Authorization
header.Note: There still seems to be some sort of an issue with the code, which I am trying to resolve. When using
client_credentials
in the test, it will sometimes fail unless it is awaited for a short time between creating the api keys and using them. Still not sure why this is happening, but am looking into it. Could always use a second pair of eyes. At the moment, I'm trying to solve it in a hacky way, using asetTimeout
.Fixes #535