Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0 #90

Merged
merged 47 commits into from
Sep 29, 2024
Merged

v1.2.0 #90

merged 47 commits into from
Sep 29, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Sep 27, 2024

Description

Package

  • Added progress updates, information, and unavailability errors to several functions
    • These can be silenced by setting options(manynet_verbosity ="quiet")
    • Where a feature is unavailable, users are directed to the Github issues page
  • Added console theme to color the startup and various warning or info messages

Making

  • Added create_ego() for collecting ego networks through interviews, including arguments for:
    • Indicating whether a roster should be used, otherwise follows a name generator approach
    • Indicating whether nodes should be interpreted, i.e. nodal attributes collected
    • Indicating whether ties between alters should be requested
  • Added create_motifs() for creating networks that correspond to the isomorphic subgraphs of certain size and format

Modifying

  • Improved print.mnet()
    • Prints multiplex types if available
    • Prints both nodesets for two-mode networks
  • Added add_info() for adding grand info to tidygraph objects
    • This includes the name of the network, node sets and ties, DOI, year and mode of collection
  • Fixed to_unweighted() so that it passes through unweighted networks correctly

Mapping

Marking

  • Improved is_multiplex() to ignore "name" tie attributes

Measuring

  • Added node_authority() and node_hub() centrality measures
  • Added node_equivalency() for calculating four-cycle closure by node
  • Extended net_equivalency() to one-mode networks

Members

  • Fixed node_in_equivalence() to use census directly

Motifs

  • Added plot methods for network_motif and node_motif classes that use create_motifs()
  • Added node_by_dyad() for node level dyad census
  • Added net_by_quad() for network level quad census
  • Fixed node_by_quad() to avoid {oaqc} dependency (Errors due to oaqc #89), more flexible but slower
  • Fixed print.node_motif() to convert to tibble and add modes and names where available only upon print
    • The underlying object is still a matrix, used for equivalence and blockmodelling

Data

  • Updated ison_southern_women with grand info
  • Updated ison_laterals with reordered nodes

Checklist:

  • PR form
    • Description above itemizes changes under subtitles, e.g. "## Data""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Longer functions are commented inline or broken down into helper functions so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

jhollway and others added 30 commits September 16, 2024 13:51
@jhollway jhollway linked an issue Sep 27, 2024 that may be closed by this pull request
@jhollway jhollway self-assigned this Sep 27, 2024
Copy link
Collaborator

@schochastics schochastics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the changes made in the quad routine are fine

Copy link
Contributor

@henriquesposito henriquesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for all the changes, all looks good on my side!

@jhollway jhollway merged commit 511b96a into main Sep 29, 2024
3 checks passed
@zpneal
Copy link
Collaborator

zpneal commented Sep 29, 2024

Sorry I didn't get to this until after the merge. The updated add_info() looks good. It should work with the current CRAN version of {grand}, but not with the development version that will go to CRAN soon. I think there are only a couple minor issues:

  • the documentation in add_info() mentions a "grand table," but support for a table output is removed from the new version of {grand}. The new version only generates a text summary.

  • in the new version of {grand}, edge.pos and edge.neg have been renamed to positive and negative respectively.

  • in the new version of {grand}, support for details about network boundaries is removed, which means there are no attributes called vertex1.total and vertex2.total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors due to oaqc
4 participants