Update url addresses to new orga and solve some issues #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'develop' into feature_simulation # Conflicts: # R/functions_estimation.R # R/functions_preprocessing.R # R/goldfish-package.R
Merge branch 'develop' into feature_simulation # Conflicts: # DESCRIPTION # NEWS.md
Merge branch 'develop' into feature_gather # Conflicts: # DESCRIPTION # NAMESPACE # NEWS.md # R/functions_estimation.R # R/functions_estimation_engine.R # R/functions_estimation_engine_c.r # R/functions_gather.R # R/functions_preprocessing.R
…fix some style code issues (`lintr`)
marion-hoffman
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
I checked whether the opportunitieslist option worked on the previous problematic examples and it works fine again!
Also I tried the prepocessingInit and summary with fixed parameters and it also seems to work.
I have not tested in detail but at least the bugs I had noticed are no longer there.
Thanks a lot for the great work
|
Can't test (on the train), but looks good @auzaheta . Thank you for the work and happy to confirm it if you also send it CRAN. |
jhollway
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is a patch change.
This fixes issues with the opportunities list and compositional change collisions, printing when fixing parameters, and a bug when using the preprocess init object. The
configure.acfile is simplified to only check for OpenMP availability. The installation from the source prints the state of the OpenMP configuration used for Goldfish during compilation.Fixes #85
Closes #83
Fixes #86
Fixes #87
Checklist: