feat_: use content-topic override for all community filters #5993
+85
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (16)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/comm-content-topic-poc #5993 +/- ##
===============================================================
- Coverage 60.60% 60.58% -0.03%
===============================================================
Files 812 812
Lines 109344 109346 +2
===============================================================
- Hits 66266 66245 -21
- Misses 35321 35328 +7
- Partials 7757 7773 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chaitanyaprem
force-pushed
the
feat/comm-content-topic-ph2
branch
2 times, most recently
from
f028f84
to
cb59e06
Compare
chaitanyaprem
requested review from
richard-ramos,
kaichaosun,
jrainville,
igor-sirotin,
osmaczko and
jm-clius
chaitanyaprem
force-pushed
the
feat/comm-content-topic-poc
branch
from
12451a8
to
d61d200
Compare
osmaczko
reviewed
Oct 31, 2024
There was a problem hiding this comment.
@chaitanyaprem can you please rebase, the diff seems wrong, thanks 🙏
chaitanyaprem
force-pushed
the
feat/comm-content-topic-ph2
branch
from
cb59e06
to
54b1cd7
Compare
chaitanyaprem
force-pushed
the
feat/comm-content-topic-poc
branch
2 times, most recently
from
b5315d5
to
103b415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is second phase of content-topic changes for communities where single content-topic is used for sending as well as receiving. This is follow-up change of #5864 and should be released only once all users have migrated to a version using #5864 as this change breaks compatibility for communities and users on any version before #5864.
Important changes:
communityVersionfield in communityDescription? Wondering if all existing communities can be labelled as version 1 and communities created after this change be version 2 and use the version to determine how content-topics shall be used.