Add style URL to the hash #62
Conversation
There was a problem hiding this comment.
There seems to be a loop that gets triggered for me that we should take care of--presumably once the style loads the store is changing and triggering a reload of the style?
To reproduce:
- Load chartographer
- Enter a URL for a valid style
- Enter a URL for a different valid style
Expected output: the style at the URL provided in (3) is visualized
Actual output: the page alternates between the URLs in (2) and (3), and you can see the style URLs in the hash alternating as well
| if (activeUrl) { | ||
| fetchStyle(activeUrl); | ||
| } | ||
| }); |
There was a problem hiding this comment.
We only really wanted this to run once, so I changed App.svelte to set variables from the hash before mounting in since we don't need anything to render first for that which sets us up to use onMount more appropriately downstream here.
|
[edit]: Found another issue to resolve first |
|
Ok, now I think this should be good to go. |
There was a problem hiding this comment.
Looking great!
One last thing: I think the selectedTab parameter in the hash is getting overridden. That is, if I load a style URL, select the lines chart, and refresh the style is loaded but the fills chart is always shown.
I'm not sure if that was introduced here, if it wasn't let's open a follow-up issue for it.
Yea, that one's a bit deeper of an issue, but an intentional choice. We decided to always flip back to the Lines 125 to 126 in fe8a56a This carries over to styles in the URL since they're treated as a new style and need a background layer. [edit]: Opened issue here: #63 |
Closes #48
If you add a style via url, that style will be added to the hash. Then on refresh, the style will be fetched again. If you add a new style via drag and drop, the url will be removed from the hash.