Enable clone3 #1971
Draft
Enable clone3 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
force-pushed
the
fix/clone3
branch
from
e6472ff
to
076bf2a
Compare
erthalion
force-pushed
the
fix/clone3
branch
2 times, most recently
from
f9ddeb5
to
6adb950
Compare
Molter73
reviewed
Nov 26, 2024
| // instead of an exec target we should see the parent file path. | ||
| func (s *ThreadsTestSuite) TestThreadExec() { | ||
| image := config.Images().QaImageByKey("qa-thread-exec") | ||
| containerID, err := s.Executor().StartContainer( |
There was a problem hiding this comment.
You might need to pass this containerID by the common.ContainerShortID() for the mock sensor to work correctly with it, see here for an example:
Originally we've excluded clone3, which wasn't present on some older platforms. But now it's getting used by newer glibc, which means that we're missing information about threads. It plays some visible role only when threads are exiting, e.g. in a weird situation if a thread will do exec, all the threads in the thread group are going to be stopped, leaving only one running exec. This is visible in the resolved file path for the event.
erthalion
force-pushed
the
fix/clone3
branch
from
6adb950
to
53b7967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally we've excluded clone3, which wasn't present on some older
platforms. But now it's getting used by newer glibc, which means that
we're missing information about threads. It plays some visible role only
when threads are exiting, e.g. in a weird situation if a thread will do
exec, all the threads in the thread group are going to be stopped,
leaving only one running exec. This is visible in the resolved file path
for the event.
Checklist
Automated testing
Testing Performed
Local testing to verify which event we receive with clone and clone3.