Apply suggestions from code review

Co-authored-by: Giles Hutton <[email protected]>
stackrox · Nov 16, 2024 · f092de4 · f092de4
1 parent 678fc86
commit f092de4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/integration-tests/pkg/mock_sensor/expect_conn.go b/integration-tests/pkg/mock_sensor/expect_conn.go
@@ -103,8 +103,7 @@ func (s *MockSensor) ExpectSameElementsConnections(t *testing.T, containerID str
 	types.SortConnections(expected)
 
 	connections := s.SortedConnections(containerID)
-	success := s.checkIfConnectionsMatchExpected(t, connections, expected)
-	if success {
+	if s.checkIfConnectionsMatchExpected(t, connections, expected) {
 		return true
 	}
 

diff --git a/integration-tests/pkg/mock_sensor/server.go b/integration-tests/pkg/mock_sensor/server.go
@@ -155,7 +155,9 @@ func (m *MockSensor) Connections(containerID string) []types.NetworkInfo {
 	defer m.networkMutex.Unlock()
 
 	if connections, ok := m.connections[containerID]; ok {
-		return connections
+        conns := make([]types.NetworkInfo, len(connections))
+        copy(conns, connections)
+        return conns
 	}
 	return make([]types.NetworkInfo, 0)
 }