Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce node protocol on built-in imports #27

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

AriPerkkio
Copy link
Member

// Before
import { readFileSync } from 'fs'
// After
import { readFileSync } from 'node:fs'

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • I have added tests for this change

@d3lm
Copy link
Collaborator

d3lm commented Jul 22, 2024

@AriPerkkio Could you resolve the conflicts in the lock file / re-generate it?

Copy link
Collaborator

@d3lm d3lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small remark.

src/configs/recommended.ts Outdated Show resolved Hide resolved
@d3lm d3lm merged commit d97cd71 into stackblitz:main Jul 23, 2024
2 checks passed
@AriPerkkio AriPerkkio deleted the feat/enforce-node-protocol branch July 23, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants