This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
Give option for AddBinding method to only call consume #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port consumeOnly option for Binding
added 2 commits
February 27, 2017 11:16
|
I won't be able to look into this until the end of the week, but couldn't you instead send an AddQueue message to the consumer, with the passive flag set to true ? I think the result would be the same ? (haven't tried though) |
|
I think you are correct about this. We will probably look at switching our code to that implementation. Much easier. I would have to test it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our AMQP servers do not permit our users to perform
declareExchangenorqueueBind. This simple solution allows the queue consumer to specify that their binding only needs to consume. Please feel free to comment on our solution. We tried not to make any breaking changes. If there is a way to do this with the existing library, we'd happily close our PR and switch to your implementation.THANKS!
The Weather Channel
SUN Team