This repository has been archived by the owner on Sep 11, 2020. It is now read-only.
Fixed path to be used fully through join and removed unused variable #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Brautigam <[email protected]>
Skarlso
force-pushed
the
fix_auth_path_with_filepath_join
branch
from
dbda1bc
to
da43cab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed two "problems".
Filepath.Join
filepath.Join(homeDirPath, "/.ssh/known_hosts"),This might be problematic on none nix environment.
I fixed in one other location.
Unused variable
The variable DefaultUsername was not accessed anywhere in the project.