Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only highlight if user nick isn't part of another word #597

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Only highlight if user nick isn't part of another word #597

merged 4 commits into from
Sep 27, 2024

Conversation

casperstorm
Copy link
Member

@casperstorm casperstorm commented Sep 25, 2024 •
edited
Loading

Fixes #590.

This fixes so that we only highlight if nickname isn't part of another word.

tarkah
tarkah reviewed Sep 26, 2024
View reviewed changes
data/src/message.rs Outdated Show resolved Hide resolved
@casperstorm
Copy link
Member Author

Take a look if you like the change @tarkah.

tarkah
tarkah approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@tarkah tarkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor nit, but all the function names could probably be s/reference/references/ since they're "conditional" checks, "if text references nickname"

@casperstorm casperstorm merged commit 9f90cb8 into main Sep 27, 2024
1 check passed
@casperstorm casperstorm deleted the fix/highlight-user branch September 27, 2024 17:12
@gAlleb gAlleb mentioned this pull request Oct 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarkah tarkah tarkah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Avoid highlighting lines where the user's nickname is part of another word
2 participants
@casperstorm @tarkah