Unicode URL Parsing #546
Merged
Unicode URL Parsing #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the regex to use the Unicode letter and number character classes instead of ASCII letter and number ranges. Also adds the examples provided in issue #545 as tests.
The conversion from
Regex::newtoRegexBuilder::newis becauseRegex::newruns into theCompiledTooBigerror because Unicode letter and number character classes are much larger than their ASCII counterparts. The documentation warns that this error is a potential sign of a slow regex. For now I bumped thesize_limit, but an alternative could be to simplify the regex. For example, if we switch the domain parsing from{1,256}and{1,63}to+and+, then the regex would again fit within the defaultsize_limit(the URL parsing would be less strict as a result, treating potential non-URLs as URLs).