-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix db2 options #661
Fix db2 options #661
Conversation
Sorry, in the mean time I had already fixed the See: 3a7a53a |
Also, if you're further interested in improving DB2 support, you might want to review the wiki pages which describe the basic syntax of various dialects. I updated the first section (identifiers, strings, etc) there with references to DB2 LUW-version and DB2i. With the LOW-version of DB2 I can test out the syntax in dbfiddle. But for DB2i I have no other sources besides the IBM documentation. The "Queries" sections is also mostly updated, the rest is still in todo status. |
That's alright - it's better that we are two thinking the same than none of us is thinking about this. 👍 |
c02a821
to
8913263
Compare
Thanks. |
Thank you for doing all this great work on the DB2 dialects! |
supportsAlterTable(format, { | ||
addColumn: true, | ||
dropColumn: true, | ||
renameColumn: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: In general instead of specifying false
here, better to just skip the option altogether. At least that's the style that the rest of the tests are following for now. Keeps the tests shorter, as like supportsAlterTable()
takes an entire 5 boolean flags.
This concrete case I already cleaned up: 91e4be0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted - only did it this way to clarify that it was on purpose in contrast to the DB2, which has true
in renameColumn
.
A fix to DB2 formatter: