Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keystatic implementation for Jobs/Freelancers #142

Closed
wants to merge 16 commits into from
Closed

Conversation

gxjansen
Copy link
Member

@gxjansen gxjansen commented Nov 4, 2024

  • Implemented Keystatic
  • Moved Freelancers data from single .json to individual .yaml files
  • linked the jobs overview page and jobs detail page with the new data structure

@gxjansen gxjansen added the enhancement New feature or request label Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for spryker-community failed. Why did it fail? →

Name Link
🔨 Latest commit 8d1f7a9
🔍 Latest deploy log https://app.netlify.com/sites/spryker-community/deploys/6740a2a2467809000845d943

@gxjansen
Copy link
Member Author

gxjansen commented Nov 4, 2024

First note: After switching laptops, didn't notice that my commits were no longer verified. Sorry for that, is fixed now.

Second note: I have no idea why commit dbbb2a6 suddenly caused the issues with CommunityTools that it did. AFAIK no CommunityTools files were affected by that commit, yet here we are.
I did manage to solve the build issues with e269787, so there's that.

@gxjansen
Copy link
Member Author

gxjansen commented Nov 7, 2024

Why KeystaticFreelancer and Freelancer? Should be just one.

What is the id? Keystatic ID or Freelancer ID? Just add the id directly as variable to freelancer.

In types.ts, keep the original order.

Either use url?: string; or url: string | null not both/mixed (preference tot he 1st).

For filenames: no spaces, and lowercase.

Check if we can config/limit the branches.

@gxjansen
Copy link
Member Author

gxjansen commented Nov 7, 2024

By default, Keystatic creates the filename based on a single field. First and Last name are split into 2 fields, so it required some additional logic to create a filename based on 2 fields.

@gxjansen gxjansen closed this Nov 23, 2024
@gxjansen gxjansen deleted the KeyStatic branch November 26, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant