adding otel capabilities #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteurer
requested review from
calebschoepp,
endocrimes,
bacongobbler and
michelleN
as code owners
|
Is there a place where I can leave instructions for how to deploy jaeger and opentelemetry-collector properly for SpinKube? |
I'd add it here https://github.com/spinkube/documentation/tree/main/content/en/docs/topics |
endocrimes
requested changes
Jul 12, 2024
endocrimes
reviewed
Jul 12, 2024
endocrimes
requested changes
Jul 18, 2024
|
Following up on this |
calebschoepp
requested changes
Aug 13, 2024
endocrimes
reviewed
Aug 15, 2024
endocrimes
reviewed
Aug 15, 2024
endocrimes
reviewed
Aug 15, 2024
endocrimes
approved these changes
Aug 16, 2024
calebschoepp
approved these changes
Aug 16, 2024
Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, a user will be able to define certain OTel parameters (which we pre-approve) that will allow them to view trace information via opentelemetry-collector and jaeger.