Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Filter and Sort using Spatie\QueryBuilder #27

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

webaction
Copy link

No description provided.

@webaction webaction closed this Feb 18, 2020
@webaction webaction reopened this Feb 18, 2020
@webaction webaction marked this pull request as ready for review February 18, 2020 05:33
@specialtactics
Copy link
Owner

Hello @webaction

Thank you very much for this PR. I have been meaning to do an integration with this and other packages for a while actually.

Unfortunately, I don't think this is the best way to go, because it's just one of many projects of it's sort, and some groups have even developed their own more elaborate implementations. My idea is to make a generic integration with this "sort" of package let's say, without any hard dependencies on any specific one.

I will keep this PR open for reference until I finished my work on that. Meanwhile if you really need it in your project, you can just use your fork, and keep it synced - I doubt there will be any major changes in this packages, until that's fully implemented.

@ramizpolic
Copy link
Contributor

ramizpolic commented Nov 6, 2020

@specialtactics Any updates on this?

# Conflicts:
#	composer.json
@specialtactics
Copy link
Owner

Not yet sorry, it's been very busy lately for me.

At the moment there are slightly higher priorities (notably laravel 8 support and related stuff), but don't worry, this is very high on my radar!

@specialtactics
Copy link
Owner

Just updated the roadmap. There's a few essentially both smaller and higher priority things (relating to laravel 8 and related changes support), but this is basically the next thing on the list in terms of new features.

https://github.com/specialtactics/laravel-api-boilerplate/wiki/Roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants