Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(w3c/sotd): update stability tempate for NOTEs #4428

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

jennyliang220
Copy link
Contributor

For Notes, use:

This Group Note is endorsed by the XXX Group, but is not endorsed by W3C itself nor its Members.

...resolves https://github.com/w3c/respec/issues/4425

src/w3c/templates/sotd.js Outdated Show resolved Hide resolved
@jennyliang220
Copy link
Contributor Author

Hi @sidvishnoi, the GH test didn't pass.

The rendered sentence is

This document was published by as a Group Note using the Note track.

without the group name. Could you please review my code?

@sidvishnoi
Copy link
Member

@jennyliang220 That was a weird bug. Took me an hour to figure out 😄

@sidvishnoi sidvishnoi changed the title Change stability tempate for NOTEs fix(w3c/sotd): update stability tempate for NOTEs Apr 17, 2023
@jennyliang220
Copy link
Contributor Author

@jennyliang220 That was a weird bug. Took me an hour to figure out 😄

Great job, @sidvishnoi

@sidvishnoi sidvishnoi merged commit 72da601 into main Apr 17, 2023
@sidvishnoi sidvishnoi deleted the note-stability branch April 17, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Group Notes' template to use another stability sentence by default.
3 participants