fix bugs in OpenLog.ino #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make this sketch work with latest library dependancies.
|
Thanks @biomurph! The changes look pretty good. I'll have time to test it out soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to make this sketch work with latest library dependencies.
As per the OpenLog Hookup Guide, the firmware running on OpenLog (OpenLog.ino) requires the use of Bill Greiman's SdFat-beta and SerialPort.
Using the latest versions of those libraries, the OpenLog.ino contains bugs that I have squashed in this pull request. Bugs are based in the SdFat library usage. I have NOT tried or tested the other OpenLog Firmware sketches.
Also, I added a feature! When you are in COMMAND_MODE you can send OpenLog a '#' and it will send back the current file number, terminated with a '\n'. You're welcome!