Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum change to SubRouter so get, post etc have same signature as Robyn #1049

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Nov 23, 2024

Fix remaining my issues in init.py

This is the minimum change to SubRouter so get, post etc have the same signature as Robyn. Should have no -ve impact as key arg auth_required defaults to false

PR Checklist

Please ensure that:

  • [X ] The PR contains a descriptive title
  • [ X] The PR contains a descriptive summary of the changes
  • [X ] You build and test your changes before submitting a PR.
  • [X ] You have added relevant documentation
  • [X ] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

…obyn. No -ve impact as key arg auto required defaults to false
Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 0:43am

Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #1049 will not alter performance

Comparing dave42w:mypy4 (d29ba56) with main (9a95611)

Summary

✅ 146 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant