Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow cors in robyn #1019

Merged
merged 4 commits into from
Nov 11, 2024
Merged

fix: allow cors in robyn #1019

merged 4 commits into from
Nov 11, 2024

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Nov 9, 2024

Description

This PR fixes #1017

Summary

This PR fixes CORS issue in Robyn

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 5:30pm

Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #1019 will degrade performances by 20.48%

Comparing fix/cors-issue (23f3e6d) with main (9f74ace)

Summary

❌ 1 regressions
✅ 145 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/cors-issue Change
test_allow_cors 361 µs 454 µs -20.48%

@sansyrox sansyrox merged commit b3750fe into main Nov 11, 2024
78 of 79 checks passed
@sansyrox sansyrox deleted the fix/cors-issue branch November 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The is some issue when assigning cors headers
1 participant