Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with Dec 2023 Roman SIAF #333

Merged

Conversation

Witchblade101
Copy link
Collaborator

Updated with XML file from #329

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a code stand point, did you test it yet to make sure you get the plot at the end @Witchblade101?

@Witchblade101
Copy link
Collaborator Author

Looks good from a code stand point, did you test it yet to make sure you get the plot at the end @Witchblade101?

No, but I'll do that now.

@Witchblade101
Copy link
Collaborator Author

I think it looks good:

`import pysiaf
import numpy as np
import matplotlib.pyplot as plt
instrument = 'Roman'
siaf = pysiaf.Siaf(instrument)

for aperture_name, aperture in siaf.apertures.items():
aperture.plot()
plt.show()`

image

@Witchblade101 Witchblade101 merged commit b9a0568 into spacetelescope:siaf-updates Mar 1, 2024
4 checks passed
@mfixstsci
Copy link
Collaborator

Cool @Witchblade101 I am good with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants