Np aliases #239
Closed
Np aliases #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfixstsci
reviewed
May 12, 2022
There was a problem hiding this comment.
@Witchblade101 I am okay with the updates using int64 and float64`. Was just curious why, for some instruments we are skipping the pre_delivery_data tests now?
| @@ -694,7 +694,8 @@ def extract_ifu_data(aperture_table): | |||
| # run some tests on the new SIAF | |||
| from pysiaf.tests import test_aperture | |||
| print('\nRunning aperture_transforms test for pre_delivery_siaf') | |||
| test_aperture.test_jwst_aperture_transforms([pre_delivery_siaf], verbose=False, threshold=0.04) | |||
| #test_aperture.test_jwst_aperture_transforms([pre_delivery_siaf], verbose=False, threshold=0.04) | |||
There was a problem hiding this comment.
Why are we skipping this test now?
mfixstsci
approved these changes
May 16, 2022
There was a problem hiding this comment.
LGTM @Witchblade101. We are still seeing the test failures from FGS, when shoud we expect that to be updated/fixed?
|
Deleting to remove skipping aperture tests. np fixes will be done in a clean branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings about np.int and np.float aliases being deprecated. See Issue #238