Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NASA Challenge_[@magnivia4consult]_[Mars Rover Demo on NVIDIA ISAAC with RVIZ based teleop and a Controller Loader] #68

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

NASA Challenge_[@magnivia4consult]_[Mars Rover Demo on NVIDIA ISAAC with RVIZ based teleop and a Controller Loader] #68

wants to merge 6 commits into from

Conversation

magnivia4Consulting
Copy link

This PR adds functionality for running the curiosity rover with NVIDIA ISAAC Simulation and provides additional functionality of tele-operation through an RViz2 plugin.

This PR requires pull request raised under simulation repository (space-ros/simulation#34) to have all the resources to run

@magnivia4Consulting magnivia4Consulting mentioned this pull request Sep 11, 2024
Open
@magnivia4Consulting magnivia4Consulting changed the title NASA Challenge_[@magnivia4consult]_[Mars Rover Demo on NVIDIA ISAAC with RVIZ based teleop and a Controller Loader Title] NASA Challenge_[@magnivia4consult]_[Mars Rover Demo on NVIDIA ISAAC with RVIZ based teleop and a Controller Loader] Sep 11, 2024
mkhansenbot
mkhansenbot previously requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@mkhansenbot mkhansenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @magnivia4Consulting - thanks for your submission. In order to ensure your code builds, you need to add a Dockerfile and a build.sh that can be run by our CI. Please see the latest README.md file in this repo for details.

@magnivia4Consulting
Copy link
Author

Hi @magnivia4Consulting - thanks for your submission. In order to ensure your code builds, you need to add a Dockerfile and a build.sh that can be run by our CI. Please see the latest README.md file in this repo for details.

Thank you for the comment, we are making the required changes.

@magnivia4Consulting
Copy link
Author

Hi @magnivia4Consulting - thanks for your submission. In order to ensure your code builds, you need to add a Dockerfile and a build.sh that can be run by our CI. Please see the latest README.md file in this repo for details.

We have added the support for Docker build, please review

@mkhansenbot
Copy link
Contributor

Running CI build flow

@magnivia4Consulting
Copy link
Author

magnivia4Consulting commented Sep 13, 2024 •
edited
Loading

Hi, Let us know if there are any other review comments. CI build check has passed

@mkhansenbot mkhansenbot dismissed their stale review September 13, 2024 20:45

Passed CI, still needs code review

@Bckempa Bckempa added the Summer Sprint NASA Space ROS Sim Summer Sprint Challenge 2024 label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkhansenbot mkhansenbot mkhansenbot left review comments

Assignees
No one assigned
Labels
Summer Sprint NASA Space ROS Sim Summer Sprint Challenge 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magnivia4Consulting @mkhansenbot @Bckempa @abhinesh4bigdipper