Push unsafety to the Rust std library #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By making use of the built in methods copy_from_slice (stable since 1.9.0) and copy_within (stable since 1.37.0) we avoid having any unsafety ourselves. This comes at the cost of potentially panicking if our assumptions don't hold. In addition I've tried to document the logic behind replace_slice a bit more and simplified the case where the source and destination slice are of equal length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making use of the built in methods copy_from_slice (stable since 1.9.0) and copy_within (stable since 1.37.0) we avoid having any
unsafety ourselves.
This comes at the cost of potentially panicking if our assumptions don't hold.
In addition I've tried to document the logic behind replace_slice a bit more and simplified the case where the source and destination slice are of equal length.