Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user can skip step #157

Merged

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Mar 26, 2024

What issues does this PR close?
closes #121 Organisation registration - User can skip to step 3 and email sent message is displayed

"After filling in all details on the User Profile page and Org profile page, directly click on Email Verification from pagination, before clicking on the Register button.

It gives an acknowledgment message to verify email has been sent but no email appears and if navigate back it shows a yes tick mark. The email is sent only when the user clicks on the Register button.

Same behavior was observed in other components with mat-stepper:

  • create-organization
  • organization-onboarding
  • provide-connector
  • register-connector
  • register-central-component
    "

Checklist

@illfixit illfixit marked this pull request as ready for review March 27, 2024 09:44
Copy link
Collaborator

@richardtreier richardtreier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 👍

@richardtreier richardtreier enabled auto-merge (squash) March 27, 2024 10:33
@richardtreier richardtreier merged commit 5efae2b into main Mar 27, 2024
7 checks passed
@richardtreier richardtreier deleted the 121-organisation-registration-user-can-skip-to-step-3 branch March 27, 2024 10:35
richardtreier added a commit that referenced this pull request Nov 18, 2024
* feat: dataOfferDetailPage

* feat: connectorDetailPage

* feat: detail pages

* feat: detail pages

* feat: detail pages

* test: detail pages

* refactor: minor refactorings

* refactor: minor refactorings

* refactor: minor test refactorings

* refactor: minor test refactorings

* refactor: minor test refactorings

* refactor: minor test refactorings

* refactor: DataOfferDetailPageQueryService

* refactor: DataOfferDetailPageQueryService

* refactor: DataOfferDetailPageQueryService

* refactor: changed models slightly, improved tests

---------

Co-authored-by: Tim Berthold <[email protected]>
Co-authored-by: Tim Berthold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organisation registration - User can skip to step 3 and email sent message is displayed
2 participants