Bug fix and changes to REPL module #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bug that the actual code area in AceEditor in REPL tab not resizes with the displayed editor area. Now AceEditor will automatically resize the code area when user drag the resize bar.
larrywang0701
changed the title
- Removed "Program exited with return value" message as Professor Martin instructed - Bug fixes: - Fix a bug that causes a runtime error to be shown in the browser's console when student provide an evaluator entry function with incorrect parameter count - Fix a bug that dose not show execution result when `null` is the execution result.
larrywang0701
changed the title
martin-henz
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
All looking good! Nice job @larrywang0701
The REPL module will be very useful in future versions of CS1101S and CS4215.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_evaluator(()=>undefined);orset_evaluator((param1,param2)=>undefined);Error: Unable to use your evaluator to run the code. Does your evaluator entry function contains and only contains exactly one parameter?to students if they make this mistake in their code.invoke_replshould beset_evaluator