Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that AceEditor in REPL tab is not notified during resize #262

Merged

Conversation

larrywang0701
Copy link
Contributor

@larrywang0701 larrywang0701 commented Oct 31, 2023

Fix the bug that the actual code area in AceEditor in REPL tab not resizes with the displayed editor area. Especially when extending the editor to a larger height, the new display area added compared to initial area will all become invalid code area that cannot display code.
image
Now AceEditor will automatically resize the code area when user drag the resize bar. When extend the editor to a larger height, all area belongs to the editor can normally display code.
image

Fix the bug that the actual code area in AceEditor in REPL tab not resizes with the displayed editor area. Now AceEditor will automatically resize the code area when user drag the resize bar.
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@martin-henz martin-henz merged commit d320b72 into source-academy:master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants