Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity Academy upgrades #251

Merged

Conversation

larrywang0701
Copy link
Contributor

@larrywang0701 larrywang0701 commented Oct 7, 2023

  • Add logging functions debug_log, debug_logwarning and debug_logerror to log messages to Unity Academy Console
  • Use Vector3 to represent coordinates in functions' parameters and return values that involve coordinates (This affects all functions that involve coordinates except Math functions)
  • Adjust Tab UI
  • Adjust GUI functions gui_label and gui_button: remove fontSize parameter for both functions (since font size can be specified directly by rich text tag size) and add width and height parameter for gui_button function
  • Add vector_difference math function and rename function name add_vector to add_vectors
  • Correct documentation mistakes and add new stuff to documentation
  • Bug fixes
  • [WIP] Audio Feature: Temporarily commented related functions in index.ts for today's deployment. I will open another PR when I totally finish audio support.

@larrywang0701 larrywang0701 self-assigned this Oct 7, 2023
Comment unfinished audio functions for the current deployment this time
 - Add documentation to introduce the usage of rich text in gui functions and logging functions
 - Add parameters: `width` and `height` for `gui_button` function
 - Remove `fontSize` parameter in functions `gui_label` and `gui_button` since font size can be specified with rich text
 - Add `vector_difference` function for calculating vecA - vecB
 - change function name `add_vector` to `add_vectors` (just the name itself)
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RichDom2185 RichDom2185 changed the title Unity Academy accumulate upgrades Unity Academy upgrades Oct 8, 2023
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps we can update the sample share link to fix the 520 error as well.

@larrywang0701
Copy link
Contributor Author

LGTM, perhaps we can update the sample share link to fix the 520 error as well.

Already updated, since old examples use old functions parameters that have changed in this new version.

@larrywang0701 larrywang0701 merged commit 518c0ab into source-academy:master Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants