-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Asynchronous Code for Loading Modules #1471
Conversation
Pull Request Test Coverage Report for Build 5936042370
💛 - Coveralls |
# Conflicts: # src/stepper/__tests__/stepper.ts
I think the interpreter in src/interpreter/interpreter.ts is no longer in use, see #1348 So what would remain to be refactored is the module loading of ec-evaluator. Note that src/interpreter/interpreter-non-det.ts does not handle modules. So that would be a nice CP3108 project. |
…ang into module-loader-async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... but I'm not sure if I'm familiar enough with the js-slang repo that I didn't miss anything
I'll do another once over myself, but if all's good I'll do the merge |
This PR is mainly aimed at addressing #1348 . I have only been able to write an async implementation for the transpiler and stepper. Both the interpreter and ec-evaluator will need further work and discussion for such implementations.
This PR also incorporates the changes from #1470 .