Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Module Documentation Available #1281

Merged
merged 26 commits into from
Sep 16, 2022
Merged

Make Module Documentation Available #1281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c52a551
Update moduleLoader.ts
leeyi45 Mar 22, 2022
4010384
Update moduleLoader.ts
leeyi45 Apr 11, 2022
8ee4e59
Update moduleLoader.ts
leeyi45 Apr 11, 2022
de6b26f
Update moduleLoader.ts
leeyi45 Apr 12, 2022
0550e21
Update moduleLoader.ts
leeyi45 Apr 12, 2022
86a39f0
Added the ability to load module documentation
leeyi45 Apr 12, 2022
1b1e60a
Update index.ts
leeyi45 Apr 12, 2022
eb82b86
Update index.ts
leeyi45 Apr 12, 2022
a44cc70
Update index.ts
leeyi45 Apr 12, 2022
1472f5a
Merge branch 'memoize_fix' into enhance_documentation
leeyi45 Apr 12, 2022
3d09073
Update index.ts
leeyi45 Apr 12, 2022
33cd010
Update index.ts
leeyi45 Apr 12, 2022
efc3750
Updated documentation loading
leeyi45 Apr 14, 2022
d6d4581
Update index.ts
leeyi45 Apr 26, 2022
d3d4234
Make js-slang load documentation
leeyi45 Aug 6, 2022
e0407f8
Update moduleLoader.ts
leeyi45 Aug 6, 2022
b90db12
Merge branch 'master' into enhance_documentation
leeyi45 Aug 6, 2022
0824bff
Moved tab conversion to module-side
leeyi45 Aug 6, 2022
b763e9b
Update moduleLoader.ts
leeyi45 Aug 6, 2022
e647e93
Update moduleLoader.ts
leeyi45 Aug 6, 2022
0fe552f
Changed how documentation is loaded
leeyi45 Aug 6, 2022
bfdde2a
Update moduleLoader.ts
leeyi45 Aug 23, 2022
eb617b0
Update moduleLoader.ts
leeyi45 Aug 23, 2022
3e7c274
Merge branch 'master' into enhance_documentation
martin-henz Sep 16, 2022
8310a0d
taking care of merge conflicts
Sep 16, 2022
f49bb8c
Update index.ts
leeyi45 Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/modules/moduleLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ const memoizedGetModuleFileInternal = memoize(getModuleFile)
export const memoizedGetModuleFile = (name: string, type: 'tab' | 'bundle' | 'json') =>
memoizedGetModuleFileInternal({ name, type })
function getModuleFile({ name, type }: { name: string; type: 'tab' | 'bundle' | 'json' }): string {
if (type === 'json') {
return httpGet(`${MODULES_STATIC_URL}/jsons/${name}.json`)
}
return httpGet(`${MODULES_STATIC_URL}/${type}s/${name}.js`)
return httpGet(`${MODULES_STATIC_URL}/${type}s/${name}.js${type === 'json' ? 'on' : ''}`)
}

/**
Expand Down
6 changes: 1 addition & 5 deletions src/name-extractor/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,7 @@ function getNames(node: es.Node, locTest: (node: es.Node) => boolean): NameDecla
}

return specs.map(spec => {
if (spec.type !== 'ImportSpecifier') {
throw new Error(`Expected ImportSpecifier, got ${spec.type}`)
}

if (docs[spec.local.name] === undefined) {
if (spec.type !== 'ImportSpecifier' || docs[spec.local.name] === undefined) {
return {
name: spec.local.name,
meta: KIND_IMPORT,
Expand Down