This repository has been archived by the owner on Oct 14, 2022. It is now read-only.
Specification fix: ensure that the initial thread can be referenced #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
threadid-spec
branch
from
b5221c5
to
a93e2b1
Compare
With the previous specification, the initially active thread (as created by starting a program) could not be referenced in transitions without violating the specification (only threads specified in createThread could be referenced). Includes a revert of 1a83971, as the check can now proceed as the ambiguity is resolved.
tautschnig
force-pushed
the
threadid-spec
branch
from
a93e2b1
to
26dfb18
Compare
mdangl
reviewed
Dec 21, 2020
| | threadId | Represents the currently active thread for the transition. If no ``threadId`` is given, any thread can be active. The value should be a unique identififer for a thread. | Yes | Yes | | ||
| | createThread | The currently active thread (value of ``threadId``) creates a new thread (value of ``createThread``) . In general, using a ``threadId`` is only allowed after creating a matching thread. The new thread's function can be entered on a second transition following this transition, such that the transition with the ``enterFunction`` key has the ``threadId`` of the created thread. When the function of the thread is exited, the thread is assumed to be terminated and its ``threadId`` should no longer be used. | Yes | Yes | | ||
| | threadId | Represents the currently active thread for the transition. The initially active thread has id ``0``. If no ``threadId`` is given, any thread can be active. The value should be a unique identififer for a thread. | Yes | Yes | | ||
| | createThread | The currently active thread (value of ``threadId``) creates a new thread (value of ``createThread``) . In general, using a ``threadId`` is only allowed after creating a matching thread, except for thread ``0``, which exits by virtue of starting the program. The new thread's function can be entered on a second transition following this transition, such that the transition with the ``enterFunction`` key has the ``threadId`` of the created thread. When the function of the thread is exited, the thread is assumed to be terminated and its ``threadId`` should no longer be used. | Yes | Yes | |
There was a problem hiding this comment.
I don't understand "which exits by virtue of starting the program".
Did you mean "exists"?
|
SV-COMP 2021 is over and I think we should merge this now? @tautschnig @mdangl @MartinSpiessl |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous specification, the initially active thread (as created
by starting a program) could not be referenced in transitions without
violating the specification (only threads specified in createThread
could be referenced).
Marked as Draft as #29 should be merged first andwe shouldn't change the spec while SV-COMP'21 is about to kick off, so let's not merge until after SV-COMP'21 has been fully executed.