Signor complexes #176
Merged
Signor complexes #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Apr 14, 2021
| @@ -15,6 +15,7 @@ inverse_is_a: HGNC:HTR7 | |||
| [Term] | |||
| id: FPLX:5_hydroxytryptamine_receptors_ionotropic | |||
| name: 5-hydroxytryptamine-receptors-ionotropic | |||
| def: "A subclass of serotonin receptors that form cation channels and mediate signal transduction by depolarizing the cell membrane. The cation channels are formed from 5 receptor subunits. When stimulated the receptors allow the selective passage of SODIUM; POTASSIUM; and CALCIUM." [mesh:D044406] | |||
There was a problem hiding this comment.
oh crazy, somehow I forgot to update the OBO file when I made the PR that added the definitions.
There was a problem hiding this comment.
I was just wondering how come the tests didn't error last time, they should normally error on any diffs in exports...
cthoyt
reviewed
Apr 14, 2021
| SIGNOR,SIGNOR-C266,MRPS | ||
| SIGNOR,SIGNOR-C304,Cohesin | ||
| SIGNOR,SIGNOR-C313,MAC | ||
| SIGNOR,SIGNOR-C317,Fibrin |
There was a problem hiding this comment.
Are you doing these by hand?
There was a problem hiding this comment.
If so, maybe we should add SIGNOR's names to PyOBO (biopragmatics/pyobo#107) then do some curation a la Biomappings style
There was a problem hiding this comment.
Yeah, I did them basically by hand. I got a dump of the SIGNOR complexes and scanned through it for things that looked familiar. I may have missed a few
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds equivalences to Signor complexes for some existing Famplex complexes. The process of finding equivalences was not completely systematic and it's possible that more equivalences can be found.