updateConfigEntry: Pass sed an escaped CFGVALUE
#1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
changed the title
sed an escaped CFGVALUE
sed will expand escape sequences in strings, so give it an escaped version of the CFGVALUE string to make updating existing config value items with backslashes work without expanding them.
Need to move it until after we map CFGVALUE booleans so that ESCAPED_CFGVALUE contains the final updated CFGVALUE.
sonic2kk
force-pushed
the
updateConfigEntry-escape-incoming-cfgvalue
branch
from
075396d
to
61bb84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #1072.
sedwill expand escape sequences in strings, so give it an escaped version of theCFGVALUEstring to make updating existing config value items with backslashes work without expanding them. For example,sedwould escape the following string, removing all backslashes and expanding the\tto be a tab character:Z:\home\gaben\testgames.Should fix updating blank config entry items to have new values with backslashes in them. For example, updating a blank
CUSTOMCMD_ARGSto haveCUSTOMCMD_ARGS="Z:\home\gaben\testgames".