Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract @interslavic/utils #247

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Jun 4, 2023

Related to: #60

The conjugation, declination functions are moved to @interslavic/utils in order to facilitate code reuse by any other Interslavic projects.

The facade remains the same so the changes are trivial and minimal. All the test cases were moved accordingly and they run 100% 🟢 as expected.

@coveralls
Copy link

coveralls commented Jun 4, 2023

Pull Request Test Coverage Report for Build 5208499450

  • 0 of 25 (0.0%) changed or added relevant lines in 5 files are covered.
  • 75 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-27.0%) to 2.787%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/services/dictionary.ts 0 1 0.0%
src/components/Modals/DetailModal/DetailModal.tsx 0 2 0.0%
src/utils/getGlagolitic/getGlagolitic.ts 0 7 0.0%
src/utils/getLatin/getLatin.ts 0 7 0.0%
src/utils/getCyrillic/getCyrillic.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/services/dictionary.ts 1 0%
src/utils/getLatin/index.ts 1 0%
src/utils/markFluentVowel/index.ts 1 0%
src/utils/wordDetails/index.ts 1 0%
src/utils/getLatin/getLatin.ts 2 0%
src/utils/markFluentVowel/markFluentVowel.ts 13 0%
src/utils/wordDetails/wordDetails.ts 56 0%
Totals Coverage Status
Change from base Build 4800820074: -27.0%
Covered Lines: 78
Relevant Lines: 2859

💛 - Coveralls

@noomorph noomorph merged commit c675f8e into master Jun 8, 2023
@noomorph noomorph deleted the refactor/extract-utils branch June 8, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants